Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: file upload fixes and misc #21

Merged
merged 3 commits into from
Sep 28, 2023
Merged

chore: file upload fixes and misc #21

merged 3 commits into from
Sep 28, 2023

Conversation

jonandernovella
Copy link
Collaborator

Related issue(s) and PR(s)

This PR closes #20

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • Updated nginx body limits to the api endpoints
  • bumped server submodule

Testing

  • rebuild and restart services
  • test document upload

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings
  • Make sure layout and text follows design sketches, if there are any

jhagberg
jhagberg reviewed Sep 28, 2023
View reviewed changes
nginx.conf
@@ -12,6 +12,7 @@ server {
proxy_pass http://client-dev:24678;
}
location /api/ {
client_max_body_size 10M;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we bump this even more? What is the file limit on the OpenAI API side?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonandernovella

@jhagberg jhagberg merged commit 8b824ae into develop Sep 28, 2023
2 checks passed
@jhagberg jhagberg deleted the dev/fix-test-rel branch September 28, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhagberg jhagberg jhagberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: context file uploads
2 participants
@jonandernovella @jhagberg